On 01/24/2018 11:45 PM, James Smart wrote:
> Existing code was using the wrong field for the completion status
> when comparing whether to increment abort statistics
>
> Signed-off-by: Dick Kennedy <dick.kennedy@xxxxxxxxxxxx>
> Signed-off-by: James Smart <james.smart@xxxxxxxxxxxx>
> ---
> drivers/scsi/lpfc/lpfc_nvmet.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_nvmet.c b/drivers/scsi/lpfc/lpfc_nvmet.c
> index 8dbf5c9d51aa..7927ac46d345 100644
> --- a/drivers/scsi/lpfc/lpfc_nvmet.c
> +++ b/drivers/scsi/lpfc/lpfc_nvmet.c
> @@ -130,7 +130,7 @@ lpfc_nvmet_xmt_ls_rsp_cmp(struct lpfc_hba *phba, struct lpfc_iocbq *cmdwqe,
> if (tgtp) {
> if (status) {
> atomic_inc(&tgtp->xmt_ls_rsp_error);
> - if (status == IOERR_ABORT_REQUESTED)
> + if (result == IOERR_ABORT_REQUESTED)
> atomic_inc(&tgtp->xmt_ls_rsp_aborted);
> if (bf_get(lpfc_wcqe_c_xb, wcqe))
> atomic_inc(&tgtp->xmt_ls_rsp_xb_set);
> @@ -541,7 +541,7 @@ lpfc_nvmet_xmt_fcp_op_cmp(struct lpfc_hba *phba, struct lpfc_iocbq *cmdwqe,
> rsp->transferred_length = 0;
> if (tgtp) {
> atomic_inc(&tgtp->xmt_fcp_rsp_error);
> - if (status == IOERR_ABORT_REQUESTED)
> + if (result == IOERR_ABORT_REQUESTED)
> atomic_inc(&tgtp->xmt_fcp_rsp_aborted);
> }
>
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
