Re: [PATCH] scsi_dh: Document alua_rtpg_queue() arguments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/24/2018 12:50 AM, Bart Van Assche wrote:
> Since commit 3a025e1d1c2e ("Add optional check for bad kernel-doc
> comments") building with W=1 causes warnings to appear for issues
> in kernel-doc headers. This patch avoids that the following warnings
> are reported when building with W=1:
> 
> drivers/scsi/device_handler/scsi_dh_alua.c:867: warning: No description found for parameter 'pg'
> drivers/scsi/device_handler/scsi_dh_alua.c:867: warning: No description found for parameter 'sdev'
> drivers/scsi/device_handler/scsi_dh_alua.c:867: warning: No description found for parameter 'qdata'
> drivers/scsi/device_handler/scsi_dh_alua.c:867: warning: No description found for parameter 'force'
> 
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>
> Cc: Hannes Reinecke <hare@xxxxxxxx>
> Cc: Johannes Thumshirn <jthumshirn@xxxxxxx>
> ---
>  drivers/scsi/device_handler/scsi_dh_alua.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 022e421c2185..4b44325d1a82 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -876,6 +876,11 @@ static void alua_rtpg_work(struct work_struct *work)
>  
>  /**
>   * alua_rtpg_queue() - cause RTPG to be submitted asynchronously
> + * @pg: ALUA port group associated with @sdev.
> + * @sdev: SCSI device for which to submit an RTPG.
> + * @qdata: Information about the callback to invoke after the RTPG.
> + * @force: Whether or not to submit an RTPG if a work item that will submit an
> + *         RTPG already has been scheduled.
>   *
>   * Returns true if and only if alua_rtpg_work() will be called asynchronously.
>   * That function is responsible for calling @qdata->fn().
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@xxxxxxxx			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux