Chenxiang, > does anyone notice and review this issue? It's a pretty crappy interface that has to have explanatory "notes" throughout the documentation saying "Don't use this the obvious way, do this instead". As evidenced by 5 drivers messing it up. Your change looks good to me. But before I apply I'd like somebody from the IBM camp to verify that fixing this doesn't unintentionally break stuff on power. -- Martin K. Petersen Oracle Linux Engineering