Re: [RFC PATCH] scsi: sd: add wce_rcd sysfs interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2018-01-18 10:51 GMT+08:00 Martin K. Petersen <martin.petersen@xxxxxxxxxx>:
>
> Hi Weiping,
>
>> add user friendly interface wce_rcd to enable/disable
>> write&read cache. The code base on cache_type, but need short input.
>
> While I agree that the cache_type interface is somewhat arcane, I don't
> think that adding a duplicate interface with slightly different
> semantics is a good idea.
>
Hi Martin,

How about add new match array for cache_type interface like following:
static const char * const sd_wce_rcd[] = {"00", "01", "10", "11"};
if cache_type match one of "sd_cache_type", "sd_wce_rcd", it will
works as before.

And, for show function, add more info, to show cache status, like following:
write back
write cache: on
read cache: on


> --
> Martin K. Petersen      Oracle Linux Engineering



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux