On 01/10/2018 09:15 AM, Christoph Hellwig wrote: > Looks fine to me for 4.15 and -stable: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > But we really need to fix this properly in the long run. > Looked into it, but I'm not sure if we can due to the fundamental differences between SCSI and libata EH. And there really is no way on how we can do async aborts on SATA; as soon as we're submitting NCQ commands _all_ commands will be aborted on error and we have to pick up the pieces. We might be handling things a tad better than now (we're always punting the abort to a workqueue, only to figure out from the workqueue function that we should've invoked SCSI EH proper). But I can't really see a better way here. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
