> On Jan 7, 2018, at 1:36 PM, Matthew R. Ochs <mrochs@xxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Jan 04, 2018 at 05:33:48PM +1100, Andrew Donnellan wrote:
>> On 04/01/18 09:54, Uma Krishnan wrote:
>>> In the event of a command failure, cxlflash returns the failure to the
>>> upper layers to process. After processing the error, when the command is
>>> queued again, the private command structure will not be zeroed and the
>>> ioasc could be stale. Per the SISLite specification, the AFU only sets the
>>> ioasc in the presence of a failure. Thus, even though the original command
>>> succeeds the second time, the command is considered a failure due to stale
>>> ioasc. This cycle repeats indefinitely and can cause a hang or IO failure.
>>>
>>> To fix the issue, clear the ioasc before queuing any command.
>>>
>>> Fixes: 479ad8e9d48c ("scsi: cxlflash: Remove zeroing of private command
>>> data")
>>> Signed-off-by: Uma Krishnan <ukrishn@xxxxxxxxxxxxxxxxxx>
>>
>> Should this go to stable?
>
> Not a bad idea.
>
I will forward the patch to stable once the patch is in next/master.
Unless there is a need to send a V2. Thanks for pointing out Andrew !!
