Hi Shivashran, On Thu, Jan 04, 2018 at 04:52:54PM +0530, Shivasharan Srikanteshwara wrote: > > -----Original Message----- > > From: Himanshu Jha [mailto:himanshujha199640@xxxxxxxxx] > > Sent: Saturday, December 30, 2017 9:18 PM > > To: martin.petersen@xxxxxxxxxx; jejb@xxxxxxxxxxxxxxxxxx > > Cc: kashyap.desai@xxxxxxxxxxxx; sumit.saxena@xxxxxxxxxxxx; > > shivasharan.srikanteshwara@xxxxxxxxxxxx; > > megaraidlinux.pdl@xxxxxxxxxxxx; linux-scsi@xxxxxxxxxxxxxxx; linux- > > kernel@xxxxxxxxxxxxxxx; mcgrof@xxxxxxxxxx; Himanshu Jha > > <himanshujha199640@xxxxxxxxx> > > Subject: [PATCH] scsi: megaraid: Use zeroing memory allocator than > > allocator/memset > > > > Use pci_zalloc_consistent for allocating zeroed memory and remove > > unnecessary memset function. > > > > Done using Coccinelle. > > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > > 0-day tested with no failures. > > > > Suggested-by: Luis R. Rodriguez <mcgrof@xxxxxxxxxx> > > Signed-off-by: Himanshu Jha <himanshujha199640@xxxxxxxxx> > > --- > > drivers/scsi/megaraid/megaraid_sas_base.c | 19 ++++++------------- > > drivers/scsi/megaraid/megaraid_sas_fusion.c | 5 ++--- > > 2 files changed, 8 insertions(+), 16 deletions(-) > > > > Hi Himanshu, > I can see one more allocation done in megasas_get_seq_num() that could > make use of these changes. Yes, I missed that case! Thanks for pointing that out. > Also, there is a driver update patchset that I am planning to post today. > Adding this patch first might require additional rebasing of this > patchset. > Would you be ok if I send a separate patch for this along with the change > mentioned above once my patch series gets committed? > That would save me some rebasing effort. :-) Yeah, sure! I have no objections for it. But this patch was not in the patchseries that I sent a while ago https://lkml.org/lkml/2017/12/30/77 Thanks Himanshu Jha
