RE: [PATCH 15/29] scsi: aacraid: Create helper functions to get lun info

[Raghava Aditya Renukunta <RaghavaAditya.Renukunta@xxxxxxxxxxxxx>]

> -----Original Message-----
> From: Bart Van Assche [mailto:Bart.VanAssche@xxxxxxx]
> Sent: Thursday, December 21, 2017 10:41 AM
> To: jejb@xxxxxxxxxxxxxxxxxx; Raghava Aditya Renukunta
> <RaghavaAditya.Renukunta@xxxxxxxxxxxxx>; linux-scsi@xxxxxxxxxxxxxxx;
> martin.petersen@xxxxxxxxxx
> Cc: dl-esc-Aacraid Linux Driver <aacraid@xxxxxxxxxxxxx>;
> gpiccoli@xxxxxxxxxxxxxxxxxx; Tom White <tom.white@xxxxxxxxxxxxx>;
> Scott Benesh <scott.benesh@xxxxxxxxxxxxx>
> Subject: Re: [PATCH 15/29] scsi: aacraid: Create helper functions to get lun
> info
> 
> EXTERNAL EMAIL
> 
> 
> On Thu, 2017-12-21 at 09:34 -0800, Raghava Aditya Renukunta wrote:
> > +     return ((phys_luns->list_length[0]<<24) +
> > +                     (phys_luns->list_length[1]<<16) +
> > +                     (phys_luns->list_length[2]<<8) +
> > +                     (phys_luns->list_length[3])) / 24;
> 
> Please use get_unaligned_be32() instead of open-coding it.

Yes Will do Bart.
Thank you
Raghava Aditya
 

> Thanks,
> 
> Bart.