On Wed, 2017-12-13 at 20:40 -0500, Douglas Gilbert wrote:
> static const struct opcode_info_t reserve_iarr[1] = {
> @@ -508,11 +508,11 @@ static const struct opcode_info_t opcode_info_arr[SDEB_I_LAST_ELEMENT + 1] = {
> 0, 0} },
> {3, 0x88, 0, F_D_IN | FF_DIRECT_IO, resp_read_dt0, read_iarr,
> {16, 0xfe, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
> - 0xff, 0xff, 0xff, 0x9f, 0xc7} }, /* READ(16) */
> + 0xff, 0xff, 0xff, 0xff, 0xc7} }, /* READ(16) */
> /* 10 */
> {3, 0x8a, 0, F_D_OUT | FF_DIRECT_IO, resp_write_dt0, write_iarr,
> {16, 0xfa, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
> - 0xff, 0xff, 0xff, 0x9f, 0xc7} }, /* WRITE(16) */
> + 0xff, 0xff, 0xff, 0xff, 0xc7} }, /* WRITE(16) */
Please mention all changes in the patch description. I think the READ(16) and
WRITE(16) changes not only change the GROUP NUMBER field from 5 to 6 bits but
also declare the DLD0 bit as supported. Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>
