On 2017/12/14 6:23, Bart Van Assche wrote:
On Wed, 2017-12-13 at 14:21 +0100, Hannes Reinecke wrote:As it turned out device_get() doesn't use kref_get_unless_zero(), so we will be always getting a device pointer. So we need to check for the device state in __scsi_remove_target() to avoid tripping over deleted objects. Fixes: fbce4d9 ("scsi: fixup kernel warning during rmmod()")How about adding Reported-by: Jason Yan? See also https://www.spinics.net/lists/linux-scsi/msg115295.html Anyway: Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>
Seems the same as my patch.So how do we plan to fix this issue, pick this approach up or the approach James Bottomley suggested? I have sent a patch to change get_device() but Greg seems do not like this way.
