On Tue, 2017-12-12 at 09:32 -0800, Linus Torvalds wrote: > On Tue, Dec 12, 2017 at 9:22 AM, Martin K. Petersen > <martin.petersen@xxxxxxxxxx> wrote: > > > > > > Arnd and Johannes fixed this up right away: > > The commit you point to _is_ the probnlem. It does: > > struct bfad_im_port_s *im_port = shost->hostdata[0]; > > which is utter bullshit crap. > > Notice? It's assigning a pointer (im_port), from an integer value > ("hostdata[0]" is "unsigned long"). > > The code is garbage. he means this one: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git/commit/?h=fixes&id=48d83282db077f93b2cf40de120f4d6f29eb293b Which properly encapsulates the reference in a function which does the correct conversions. James