On Tue, 2017-12-12 at 08:52 +0100, Christoph Hellwig wrote: > On Mon, Dec 11, 2017 at 04:08:03PM -0800, Bart Van Assche wrote: > > + if (!((__force unsigned int)sdev->sdev_bflags & BIT(i))) > > I'd case the right side argument to __force blist_flags_t here for > purely esthetic reasons. > > Except for that this looks fine to me: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Hello Christoph, Thanks for the review. I will make the proposed change and repost this patch. Bart.