On Mon, 2017-11-27 at 23:47 +0100, Martin Wilck wrote: > + /* This zero-pads the destination */ > + strncpy(to, from, to_length); > + if (from_length < to_length && !compatible) > + /* > + * space pad the string if it is short. > + */ > + memset(&to[from_length], ' ', to_length - from_length); Since the code block controlled by the if-statement consists of multiple lines, shouldn't that block be surrounded by braces ({})? Anyway: Reviewed-by: Bart Van Assche <bart.vanassche@xxxxxxx>