On Thu, 2017-11-23 at 09:18 +0100, Christoph Hellwig wrote: > > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c > > index 5e89049e9b4e..f7f014c755d7 100644 > > --- a/drivers/scsi/scsi_error.c > > +++ b/drivers/scsi/scsi_error.c > > @@ -61,9 +61,10 @@ static int scsi_eh_try_stu(struct scsi_cmnd *scmd); > > static int scsi_try_to_abort_cmd(struct scsi_host_template *, > > struct scsi_cmnd *); > > > > -/* called with shost->host_lock held */ > > void scsi_eh_wakeup(struct Scsi_Host *shost) > > { > > + lockdep_assert_held(shost->host_lock); > > + > > if (atomic_read(&shost->host_busy) == shost->host_failed) { > > trace_scsi_eh_wakeup(shost); > > wake_up_process(shost->ehandler); > > Can you split this comment to assert change into a separate patch, please? Hello Christoph. Thanks for the review. I will make the requested change. Bart.