On 11/10/2017 02:08 AM, James Smart wrote: > The logic for sg_seg_cnt is a bit convoluted. This patch tries to > clean up a couple of areas, especially around the +2 and +1 logic. > > This patch: > - cleans up the lpfc_sg_seg_cnt attribute to specify a real minimum > rather than making the minimum be whatever the default is. > - Remove the hardcoding of +2 (for the number of elements we use in > a sgl for cmd iu and rsp iu) and +1 (an additional entry to > compensate for nvme's reduction of io size based on a possible > partial page) logic in sg list initialization. In the case where > the +1 logic is referenced in host and target io checks, use the > values set in the transport template as that value was properly set. > > There can certainly be more done in this area and it will be addressed > in combined host/target driver effort. > > Signed-off-by: Dick Kennedy <dick.kennedy@xxxxxxxxxxxx> > Signed-off-by: James Smart <james.smart@xxxxxxxxxxxx> > --- > drivers/scsi/lpfc/lpfc.h | 1 + > drivers/scsi/lpfc/lpfc_attr.c | 2 +- > drivers/scsi/lpfc/lpfc_init.c | 19 ++++++++++++++----- > drivers/scsi/lpfc/lpfc_nvme.c | 3 ++- > drivers/scsi/lpfc/lpfc_nvmet.c | 2 +- > 5 files changed, 19 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
