Re: [PATCH 1/3] device information: Do not interpret error codes as flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bart.vanassche@xxxxxxx>
Subject: Re: [PATCH 1/3] device information: Do not interpret error codes as flags
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 15 Nov 2017 18:57:03 -0500
Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, "Johannes Thumshirn" <jthumshirn@xxxxxxx>
In-reply-to: <20171115023317.3595-2-bart.vanassche@wdc.com> (Bart Van Assche's message of "Tue, 14 Nov 2017 18:33:15 -0800")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hi Bart,

> This patch also avoids that error codes returned by
> scsi_get_device_flags_keyed() are interpret as device flags.

Nobody expects this and scsi_get_device_flags() to ever return an
error. So I'd rather have the != -ENOENT case fixed up to return 0.

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH 0/3] Improve device information handling
  - From: Bart Van Assche
- [PATCH 1/3] device information: Do not interpret error codes as flags
  - From: Bart Van Assche

Prev by Date: mvsas sata drives with high ioerr_cnt and long stalls
Next by Date: Re: [PATCH 3/3] Introduce a type for device information flags, namely bflags_t
Previous by thread: [PATCH 1/3] device information: Do not interpret error codes as flags
Next by thread: [PATCH 2/3] Constify scsi_dev_info_list_add_keyed() string arguments
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]