Hello Martin, There are multiple issues with the device information flag handling (a.k.a. blacklist flags): * For neither scsi_get_device_flags() nor scsi_get_device_flags_keyed() it is possible to determine whether an error code has been returned or whether the flag with bit position 31 was set. * A large number of sparse warnings is generated by the blacklist flags code. The three patches in this series address these issues. Please consider these patches for inclusion in the upstream kernel. Thanks, Bart. Bart Van Assche (3): device information: Do not interpret error codes as flags Constify scsi_dev_info_list_add_keyed() string arguments Introduce a type for device information flags, namely bflags_t drivers/scsi/scsi_devinfo.c | 48 +++++++++++++++++++----------------- drivers/scsi/scsi_priv.h | 12 +++++---- drivers/scsi/scsi_scan.c | 28 +++++++++++---------- drivers/scsi/scsi_sysfs.c | 4 +-- drivers/scsi/scsi_transport_spi.c | 11 +++++---- include/scsi/scsi_device.h | 3 ++- include/scsi/scsi_devinfo.h | 52 ++++++++++++++++++++------------------- include/scsi/scsi_types.h | 6 +++++ 8 files changed, 90 insertions(+), 74 deletions(-) create mode 100644 include/scsi/scsi_types.h -- 2.15.0
