Re: [PATCH] scsi: ufs: Fix Runtime PM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michał,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on scsi/for-next]
[also build test WARNING on v4.14-rc8 next-20171109]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Michal-Potomski/scsi-ufs-Fix-Runtime-PM/20171110-191314
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-randconfig-v0-11102116 (attached as .config)
compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/async.h:15,
                    from drivers/scsi/ufs/ufshcd.c:40:
   drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_pm_runtime_get':
   drivers/scsi/ufs/ufshcd.c:246:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
     if (dev->power.runtime_status == RPM_RESUMING ||
                   ^
   include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/scsi/ufs/ufshcd.c:246:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:247:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
         dev->power.runtime_status == RPM_SUSPENDING)
                   ^
   include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/scsi/ufs/ufshcd.c:246:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:246:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
     if (dev->power.runtime_status == RPM_RESUMING ||
                   ^
   include/linux/compiler.h:156:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> drivers/scsi/ufs/ufshcd.c:246:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:247:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
         dev->power.runtime_status == RPM_SUSPENDING)
                   ^
   include/linux/compiler.h:156:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> drivers/scsi/ufs/ufshcd.c:246:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:246:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
     if (dev->power.runtime_status == RPM_RESUMING ||
                   ^
   include/linux/compiler.h:167:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> drivers/scsi/ufs/ufshcd.c:246:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:247:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
         dev->power.runtime_status == RPM_SUSPENDING)
                   ^
   include/linux/compiler.h:167:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> drivers/scsi/ufs/ufshcd.c:246:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_pm_runtime_put':
   drivers/scsi/ufs/ufshcd.c:258:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
     if (dev->power.runtime_status == RPM_RESUMING ||
                   ^
   include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
   drivers/scsi/ufs/ufshcd.c:258:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:259:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
         dev->power.runtime_status == RPM_SUSPENDING)
                   ^
   include/linux/compiler.h:156:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
   drivers/scsi/ufs/ufshcd.c:258:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:258:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
     if (dev->power.runtime_status == RPM_RESUMING ||
                   ^
   include/linux/compiler.h:156:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
   drivers/scsi/ufs/ufshcd.c:258:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:259:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
         dev->power.runtime_status == RPM_SUSPENDING)
                   ^
   include/linux/compiler.h:156:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
   drivers/scsi/ufs/ufshcd.c:258:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:258:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
     if (dev->power.runtime_status == RPM_RESUMING ||
                   ^
   include/linux/compiler.h:167:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
   drivers/scsi/ufs/ufshcd.c:258:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~
   drivers/scsi/ufs/ufshcd.c:259:16: error: 'struct dev_pm_info' has no member named 'runtime_status'
         dev->power.runtime_status == RPM_SUSPENDING)
                   ^
   include/linux/compiler.h:167:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
   drivers/scsi/ufs/ufshcd.c:258:2: note: in expansion of macro 'if'
     if (dev->power.runtime_status == RPM_RESUMING ||
     ^~

vim +/if +246 drivers/scsi/ufs/ufshcd.c

   242	
   243	static void ufshcd_pm_runtime_get(struct device *dev)
   244	{
   245		// Don't trigger PM events while in transition states
 > 246		if (dev->power.runtime_status == RPM_RESUMING ||
   247		    dev->power.runtime_status == RPM_SUSPENDING)
   248			pm_runtime_get_noresume(dev);
   249		else
   250			pm_runtime_get_sync(dev);
   251	}
   252	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux