Re: [PATCH 4/4] qla2xxx_nvmet: Add FC-NVMe Target handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Anil,

I love your patch! Perhaps something to improve:

[auto build test WARNING on scsi/for-next]
[also build test WARNING on next-20171106]
[cannot apply to v4.14-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Himanshu-Madhani/qla2xxx-Add-FC-NVMe-Target-support/20171107-153645
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All warnings (new ones prefixed by >>):

   drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_send_els_resp':
>> drivers/scsi/qla2xxx/qla_target.c:400:6: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 7 has type 'dma_addr_t' [-Wformat=]
         sp, purex, udma, loop_id);
         ^
   drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_nvme_els_done':
   drivers/scsi/qla2xxx/qla_target.c:446:6: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 8 has type 'dma_addr_t' [-Wformat=]
         sp->gen1);
         ^
   drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_send_plogi_resp':
   drivers/scsi/qla2xxx/qla_target.c:475:6: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 8 has type 'dma_addr_t' [-Wformat=]
         sp, vha, plogi_ack_buf, plogi_ack_udma);
         ^
   drivers/scsi/qla2xxx/qla_target.c:488:40: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
     ret = qla2x00_get_plogi_template(vha, (uint64_t)tmp, (116/4 - 1));
                                           ^
   drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_process_logo':
   drivers/scsi/qla2xxx/qla_target.c:689:6: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 8 has type 'dma_addr_t' [-Wformat=]
         sp, vha, logo_ack_buf, logo_ack_udma);
         ^
   drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_process_prli':
   drivers/scsi/qla2xxx/qla_target.c:754:6: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 8 has type 'dma_addr_t' [-Wformat=]
         sp, vha, prli_ack_buf, prli_ack_udma);
         ^

vim +400 drivers/scsi/qla2xxx/qla_target.c

   375	
   376	/* Send an ELS response */
   377	int qlt_send_els_resp(srb_t *sp, struct __els_pt *els_pkt)
   378	{
   379		struct purex_entry_24xx *purex = (struct purex_entry_24xx *)
   380						sp->u.snvme_els.ptr;
   381		dma_addr_t udma = sp->u.snvme_els.dma_addr;
   382		struct fc_port *fcport;
   383		port_id_t port_id;
   384		uint16_t loop_id;
   385	
   386		port_id.b.domain = purex->s_id[2];
   387		port_id.b.area   = purex->s_id[1];
   388		port_id.b.al_pa  = purex->s_id[0];
   389		port_id.b.rsvd_1 = 0;
   390	
   391		fcport = qla2x00_find_fcport_by_nportid(sp->vha, &port_id, 1);
   392		if (fcport)
   393			/* There is no session with the swt */
   394			loop_id = fcport->loop_id;
   395		else
   396			loop_id = 0xFFFF;
   397	
   398		ql_log(ql_log_info, sp->vha, 0xfff9,
   399		    "sp: %p, purex: %p, udam: %#llx, loop_id: 0x%x\n",
 > 400		    sp, purex, udma, loop_id);
   401	
   402		els_pkt->entry_type = ELS_IOCB_TYPE;
   403		els_pkt->entry_count = 1;
   404	
   405		els_pkt->handle = sp->handle;
   406		els_pkt->nphdl = cpu_to_le16(loop_id);
   407		els_pkt->tx_dsd_cnt = cpu_to_le16(1);
   408		els_pkt->vp_index = purex->vp_idx;
   409		els_pkt->sof = EST_SOFI3;
   410		els_pkt->rcv_exchg_id = cpu_to_le32(purex->rx_xchg_addr);
   411		els_pkt->op_code = sp->cmd_type;
   412		els_pkt->did_lo = cpu_to_le16(purex->s_id[0] | (purex->s_id[1] << 8));
   413		els_pkt->did_hi = purex->s_id[2];
   414		els_pkt->sid_hi = purex->d_id[2];
   415		els_pkt->sid_lo = cpu_to_le16(purex->d_id[0] | (purex->d_id[1] << 8));
   416	
   417		if (sp->gen2 == ELS_ACC)
   418			els_pkt->cntl_flags = cpu_to_le16(EPD_ELS_ACC);
   419		else
   420			els_pkt->cntl_flags = cpu_to_le16(EPD_ELS_RJT);
   421	
   422		els_pkt->tx_bc = cpu_to_le32(sp->gen1);
   423		els_pkt->tx_dsd[0] = cpu_to_le32(LSD(udma));
   424		els_pkt->tx_dsd[1] = cpu_to_le32(MSD(udma));
   425		els_pkt->tx_dsd_len = cpu_to_le32(sp->gen1);
   426		/* Memory Barrier */
   427		wmb();
   428	
   429		ql_log(ql_log_info, sp->vha, 0x11030, "Dumping PLOGI ELS\n");
   430		ql_dump_buffer(ql_dbg_disc + ql_dbg_buffer, sp->vha, 0xffff,
   431			(uint8_t *)els_pkt, sizeof(*els_pkt));
   432	
   433		return 0;
   434	}
   435	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux