On Wed, 2017-11-01 at 19:18 +0000, Madhani, Himanshu wrote: > Hi Kees, > > > On Nov 1, 2017, at 11:46 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > > On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: > > > This breaks out the logical steps to convert the qla2xxx timers: > > > > > > 1) init_timer() -> setup_timer() > > > 2) refactor qla2x00_start_timer() to not pass callback as argument > > > 3) qla2x00_timer() to use timer_setup() > > > 4) qla2x00_sp_timeout() to use timer_setup() > > > > > > The resulting diff is identical to the patch that appears to lock up > > > the driver. This should help identify which step causes this behavior. > > > > Hi, just curious if there's been any progress on debugging the issue > > you saw with this series? > > Sorry for delay. I will test this series later today and post update. Hello Himanshu and Kees, The qla2xxx driver does not crash if apply these four patches on kernel v4.14-rc8 and load the qla2xxx driver on my test setup. Point-to-point mode seems broken again but I don't think that's related to this patch series. Bart.
