On 03/11/2017 10:19, Arnd Bergmann wrote:
On Fri, Nov 3, 2017 at 11:14 AM, John Garry <john.garry@xxxxxxxxxx> wrote:
+ Shiju, who authored the original patch
index d42f29a5eb65..6ad8a6251d21 100644
--- a/drivers/scsi/hisi_sas/Kconfig
+++ b/drivers/scsi/hisi_sas/Kconfig
@@ -4,6 +4,7 @@ config SCSI_HISI_SAS
depends on ARM64 || COMPILE_TEST
select SCSI_SAS_LIBSAS
select BLK_DEV_INTEGRITY
+ select RAS
My impression is that we don't want this. Correction: shouldn't want this.
Do you have the .config for the broken build? I couldn't recreate this by
turning off CONFIG_RAS.
Uploaded to https://pastebin.com/A1rJYhDr
Maybe you were missing support for tracing in your configuration?
Thanks Arnd, I can see it now.
However, as you said, it looks like this interface is not being used
correctly, and I tend to agree.
Actually this interface is intended for logging UEFI CPER non-standard
records from kernel RAS/APEI framework to userspace. It is not intended
for kernel peripheral driver logging (like this case). Until we get a
community concensus on whether this is acceptable, I would rather revert
the original patch.
Thanks,
John
Arnd
.
