On 1 November 2017 at 15:45, Bart Van Assche <Bart.VanAssche@xxxxxxx> wrote: > On Wed, 2017-11-01 at 15:17 +0000, Ard Biesheuvel wrote: >> On 1 November 2017 at 14:50, Bart Van Assche <Bart.VanAssche@xxxxxxx> wrote: >> > On Mon, 2017-10-16 at 15:49 -0700, Bart Van Assche wrote: >> > > Use the sgl_alloc() and sgl_free() functions instead of open coding >> > > these functions. >> > > >> > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx> >> > > Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> >> > > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> >> > >> > Ard and/or Herbert, can you please have a look at this patch and let us know >> > whether or not it looks fine to you? >> >> The patch itself does not look unreasonable, but I can't find >> sgl_alloc() anywhere in the source tree. Given that you have cc'ed me >> on this patch only, I can only assume that you are adding this as part >> of the series, but without any context, I can't really review this, >> sorry. > > Hello Ard, > > Do you expect to be Cc-ed personally or is Cc-ing the linux-crypto mailing > list sufficient? The linux-crypto mailing list was Cc-ed for the entire patch > series as one can see here: > https://www.mail-archive.com/linux-crypto@xxxxxxxxxxxxxxx/msg28485.html. > I guess people's opinions may differ regarding what they want to be cc'ed on, but in general, you should at least cc everyone on the cover letter if you cc them on individual patches, and in my case, I'd rather have the whole series even if only a single patch is relevant to me.
