On Tue, Oct 31, 2017 at 11:36 AM, Madhani, Himanshu <Himanshu.Madhani@xxxxxxxxxx> wrote: > Hi Kees, > >> On Oct 31, 2017, at 11:28 AM, Kees Cook <keescook@xxxxxxxxxxxx> wrote: >> >> How very strange. I don't see any code change with this patch. Even >> the passed arguments are the same; it's only enforcing the types now. >> And the system is fine with only this patch reverted? > > Yes. Agree patch looks okay, but with the patch built into driver I see > system going into infinite loop of trying to bring link up and lock up > after few minutes, Only way to recover is hard reboot. > > I reverted this patch after system boot up and rebuild qla2xxx and able > to load driver. The patch is a result of three logical steps, so maybe something unexpected is happening. I'll send the 3 steps broken out... -Kees -- Kees Cook Pixel Security
