>> If you use alloc_ordered_workqueue directly instead of >> create_singlethread_workqueue you can pass a format string and don't >> need the separate allocation. >> >> But I'm not sure if Tejun is fine with using __WQ_LEGACY directly.. > > The only thing that flag does is exempting the workqueue from possible > flush deadlock check as we don't know whether WQ_MEM_RECLAIM on a > legacy workqueue is intentional. There's no reason to add it when > converting to alloc_ordered_workqueue(). Just decide whether it needs > forward progress guarantee and use WQ_MEM_RECLAIM if so. Cathy? -- Martin K. Petersen Oracle Linux Engineering