Mike Anderson wrote:
What about using netlink attributes? The attributes do have more overhead, but it would seem that using attributes instead of sending out a whole structure would make it easier on the user space side to support different kernel versions without syncing the tools with the kernel.
Yeah, I guessed you were going to raise this. I just didn't see any advantage to it. The macros really didn't help with anything really interesting, such as endianness. I guess they do help with some potential structure packing issues. I saw them as just ensuring that you walked on the path right - which for most intents and purposes, you will as you really are not self-discovering data. As long as you use well-defined types and watch the structure alignments, it should be fine. The overhead didn't seem worthit. Enlighten me if I'm taking them too lightly. I'm assuming your "syncing the tools with the kernel" statement infers the use of a version element in place of the attributes above. I don't see how you lose the version. It's the key for the later structure decode regardless of whether it's attribute-ized or not. Am I missing something ? I'm also (obviously) a proponent of the version so that a tool can provide backward compatibility, or spot new un-recognized data. -- james - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
