Re: [PATCH] scsi: Always retry internal target error

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hannes,

> +		if (!strncmp(scmd->device->vendor, "EMC", 3) &&
> +		    !strncmp(scmd->device->model, "SYMMETRIX", 9) &&
> +		    (sshdr.asc == 0x44) && (sshdr.ascq == 0x0)) {
> +			/*
> +			 * EMC Symmetrix returns 'Internal target failure'
> +			 * for a variety of internal issues, all of which
> +			 * can be recovered by retry.
> +			 */
> +			return ADD_TO_MLQUEUE;
> +		}

It's decidedly awful to have vendor/model-specific triggers in
scsi_error.

What are the drawbacks of just always refiring on AC/0x44/ITF?

-- 
Martin K. Petersen	Oracle Linux Engineering



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux