Hi Johannes, > On Oct 12, 2017, at 12:19 AM, Johannes Thumshirn <jthumshirn@xxxxxxx> wrote: > > On Wed, Oct 11, 2017 at 01:36:46PM -0700, Madhani, Himanshu wrote: > [...] >> +int ql2xenablemsix = 1; >> +module_param(ql2xenablemsix, int, 0444); >> +MODULE_PARM_DESC(ql2xenablemsix, >> + "Set to enable MSI or MSI-X interrupt mechanism.\n" >> + " Default is 1, enable MSI-X interrupt mechanism.\n" >> + " 0 -- enable traditional pin-based mechanism.\n" >> + " 1 -- enable MSI-X interrupt mechanism.\n" >> + " 2 -- enable MSI interrupt mechanism.\n"); > > Maybe qla2xirqmode is a more appropriate name? > Sorry this one slipped out of my sight. The reason I used "ql2xenablemsix" was because driver already had this parameter in code until few versions back where we removed it. Since existing user are familiar with this module parameter name, it would be easy to keep that same. Let me know if you are okay with the name or prefer new name instead? > -- > Johannes Thumshirn Storage > jthumshirn@xxxxxxx +49 911 74053 689 > SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg > GF: Felix Imendörffer, Jane Smithard, Graham Norton > HRB 21284 (AG Nürnberg) > Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850 Thanks, - Himanshu
