On Wed, 09 Aug 2006, David Somayajulu wrote: > On Wed, 2006-08-09 at 13:56 -0400, Mike Christie wrote: > > Doug Maxey wrote: > > > From: Doug Maxey <dwm@xxxxxxxxxxx> > > > > > > Move the defn before the caller, and remove the decl. > > > > > > > I think not doing the defn before the caller is nice, but I honestly > > could care less either way as far as merging things goes (it seems like > > Christoph hates then but people like Jeff let the driver writer do what > > they want). Qlogic seems to love doing it, so are they ok with all these > > patches? > We have no problem with these patches since it makes the code cleaner > and makes everyone happy. So, would you folks (Mike/James) like the qla4xxx patches respun with Doug's changes? Or will Dave S's original submission be added to scsi-misc-2.6.git with the fixup/cleanups on top? Thanks, AV - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html