Re: [PATCH] scsi: sd: add check for changing allow_restart

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: weiping zhang <zhangweiping@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] scsi: sd: add check for changing allow_restart
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Wed, 11 Oct 2017 13:22:18 -0400
Cc: <martin.petersen@xxxxxxxxxx>, <jejb@xxxxxxxxxxxxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>
In-reply-to: <20170927165313.GA36250@localhost.didichuxing.com> (weiping zhang's message of "Thu, 28 Sep 2017 00:53:18 +0800")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

weiping,

> /sys/class/scsi_disk/0:2:0:0/allow_restart can be changed to 0 unexpectly by
> writing invalid string, like following:
>
> echo asdf > /sys/class/scsi_disk/0:2:0:0/allow_restart

Please switch to kstrtobool() and fix up manage_start_stop as well.

Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH] scsi: sd: add check for changing allow_restart
  - From: weiping zhang

References:
- [PATCH] scsi: sd: add check for changing allow_restart
  - From: weiping zhang

Prev by Date: Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset
Next by Date: Re: [PATCH 04/10] mpt3sas: Fix removal and addition of vSES device during host reset
Previous by thread: Re: [PATCH] scsi: sd: add check for changing allow_restart
Next by thread: Re: [PATCH] scsi: sd: add check for changing allow_restart
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux