On 10/10/2017 09:32 PM, Kyle Fortin wrote:
On Oct 10, 2017, at 3:05 PM, Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Update the description of 'scsi_logging_level' from 8 4-bit nibbles
to the (pre-git) reality of 10 3-bit 'nibbles'.
Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
---
drivers/scsi/scsi_logging.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--- lnx-414-rc3.orig/drivers/scsi/scsi_logging.h
+++ lnx-414-rc3/drivers/scsi/scsi_logging.h
@@ -3,10 +3,10 @@
/*
- * This defines the scsi logging feature. It is a means by which the user
- * can select how much information they get about various goings on, and it
- * can be really useful for fault tracing. The logging word is divided into
nit pick: Why reflow and thus "change" these 3 lines even though the
content is the same?
- * 8 nibbles, each of which describes a loglevel. The division of things is
+ * This defines the scsi logging feature. It is a means by which the user can
+ * select how much information they get about various goings on, and it can be
+ * really useful for fault tracing. The logging word is divided into 10 3-bit
+ * 'nibbles', each of which describes a loglevel. The division of things is
I think ‘bitfields' is more appropriate than ‘nibbles’ (a 4-bit construct in compute).
+1
* somewhat arbitrary, and the division of the word could be changed if it
* were really needed for any reason. The numbers below are the only place
* where these are specified. For a first go-around, 3 bits is more than
Reviewed-by: Kyle Fortin <kyle.fortin@xxxxxxxxxx>
Reviewed-by: Steffen Maier <maier@xxxxxxxxxxxxxxxxxx>
--
Mit freundlichen Grüßen / Kind regards
Steffen Maier
Linux on z Systems Development
IBM Deutschland Research & Development GmbH
Vorsitzende des Aufsichtsrats: Martina Koederitz
Geschaeftsfuehrung: Dirk Wittkopp
Sitz der Gesellschaft: Boeblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294
