Variable spp->cpp_index is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas <chris.gekas@xxxxxxxxx> --- drivers/scsi/eata.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/eata.c b/drivers/scsi/eata.c index 6501c33..53a8fcd 100644 --- a/drivers/scsi/eata.c +++ b/drivers/scsi/eata.c @@ -2332,12 +2332,11 @@ static irqreturn_t ihdlr(struct Scsi_Host *shost) printk ("%s: ihdlr, spp->eoc == 0, irq %d, reg 0x%x, count %d.\n", ha->board_name, irq, reg, ha->iocount); - if (spp->cpp_index < 0 || spp->cpp_index >= shost->can_queue) + if (spp->cpp_index >= shost->can_queue) printk ("%s: ihdlr, bad spp->cpp_index %d, irq %d, reg 0x%x, count %d.\n", ha->board_name, spp->cpp_index, irq, reg, ha->iocount); - if (spp->eoc == 0 || spp->cpp_index < 0 - || spp->cpp_index >= shost->can_queue) + if (spp->eoc == 0 || spp->cpp_index >= shost->can_queue) goto handled; /* Find the mailbox to be serviced on this board */ -- 2.7.4