On Wed, Oct 04, 2017 at 09:18:11AM +0200, Johannes Thumshirn wrote: > Wouldn't it make sense to put the ->release() method into bsg_ops as > well? The current prototype of bsg_register_queue isn't exactly what I > would call a sane API. It's a different level of callback - ops are the type of request passed through (scsi vs transport) and ->release is s whacky implementation detail of the SAS passthrough. If at all ->release should go away eventually by cleaning that mess up.