On 10/03/2017 12:48 PM, Christoph Hellwig wrote: > Always use bsg_job->reply instead of scsi_req(bsg_job->req)->sense), as > they always point to the same memory. > > Never set scsi_req(bsg_job->req)->result and we'll set that value through > bsg_job_done. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > --- > drivers/scsi/qla2xxx/qla_bsg.c | 10 ++++------ > drivers/scsi/qla2xxx/qla_isr.c | 12 +++--------- > drivers/scsi/qla2xxx/qla_mr.c | 3 +-- > 3 files changed, 8 insertions(+), 17 deletions(-) > [ .. ] > @@ -2571,7 +2569,7 @@ qla24xx_bsg_timeout(struct bsg_job *bsg_job) > } > spin_unlock_irqrestore(&ha->hardware_lock, flags); > ql_log(ql_log_info, vha, 0x708b, "SRB not found to abort.\n"); > - scsi_req(bsg_job->req)->result = bsg_reply->result = -ENXIO; > + bsg_reply->result = -ENXIO; > return 0; > > done: Whitespace issue ... Otherwise: Reviwed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
