On Mon, 2017-09-25 at 21:17 +0000, Bart Van Assche wrote: > On Mon, 2017-09-25 at 15:14 +0900, Damien Le Moal wrote: > > + return kzalloc_node(BITS_TO_LONGS(sdkp->nr_zones) > > + * sizeof(unsigned long), > > Does this perhaps fit on one line? > > > +/** > > + * sd_zbc_get_seq_zones - Parse report zones reply to identify sequential > > zones > > + * @sdkp: disk used > > + * @buf: report reply buffer > > + * @seq_zone_bitamp: bitmap of sequential zones to set > > + * @zno: Zone number of the first zone in the report > > 'zno' is an input and output parameter but the above line only describes > what > happens with the value passed to sd_zbc_get_seq_zones(). I think we also > need a > description for the value of 'zno' upon return. zno is not necessary since it can be calculated from the reported zone start LBA. So I removed it in V6 to simplify. -- Damien Le Moal Western Digital
