> +static struct request * > +deadline_next_request(struct deadline_data *dd, int data_dir) > +{ if (WARN_ON_ONCE(data_dir != READ && data_dir != WRITE)) return NULL; > + return dd->next_rq[data_dir]; > +} > + Else looks fine to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>