On 9/15/17 19:44, Hannes Reinecke wrote: > On 09/15/2017 12:06 PM, Damien Le Moal wrote: >> Fix comments style (do not use documented comment style) and add some >> comments to clarify some functions. Also fix some functions signature >> indentation and remove a useless blank line in sd_zbc_read_zones(). >> >> No functional change is introduced by this patch. >> >> Signed-off-by: Damien Le Moal <damien.lemoal@xxxxxxx> >> --- >> drivers/scsi/scsi_lib.c | 5 +++- >> drivers/scsi/sd_zbc.c | 67 ++++++++++++++++++++++++++++++++++++------------- >> 2 files changed, 53 insertions(+), 19 deletions(-) >> > Actually you should've used kernel-doc style to format the comments; > just to keep the 0-day bot happy.... I thought that comments to functions with the kernel-doc format was only if you want the function to be documented. That generally includes at least all the exported functions. In this case, the functions are mostly local to sd_zbc.c... I thought the documentation of those was not very useful. I can revert though. No problem at all. Thanks ! -- Damien Le Moal Western Digital Research
