Re: [PATCH V4 08/10] block: allow to allocate req with RQF_PREEMPT when queue is preempt frozen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-09-14 at 09:15 +0800, Ming Lei wrote:
> On Wed, Sep 13, 2017 at 07:07:53PM +0000, Bart Van Assche wrote:
> > On Thu, 2017-09-14 at 01:48 +0800, Ming Lei wrote:
> > > No, that patch only changes blk_insert_cloned_request() which is used
> > > by dm-rq(mpath) only, nothing to do with the reported issue during
> > > suspend and sending SCSI Domain validation.
> > 
> > There may be other ways to fix the SCSI domain validation code.
> 
> Again the issue isn't in domain validation, it is in quiesce,
> so we need to fix quiesce, instead of working around transport_spi.
> 
> Also What is the other way? Why not this patchset?

Sorry if I had not made this clear enough but I don't like the approach of
this patch series so please do not expect any "Reviewed-by" tags from me.
As the discussion about v4 of this patch series made clear the interaction
between blk_cleanup_queue() and the changes introduced by this patch series
in blk_get_request() is subtle and hard to analyze. The blk-mq core is
already complicated. In my view patches that make the blk-mq core simpler
are much more welcome than patches that make the blk-mq core more
complicated.

Since I expect that any fix for the interaction between blk-mq and power
management will be integrated in kernel v4.15 at earliest there is no reason
to rush. My proposal is to wait a few weeks and to see whether anyone comes
up with a better solution.

Bart.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux