Christoph,
On 9/14/17 05:17, Christoph Hellwig wrote:
> On Tue, Sep 12, 2017 at 05:38:05PM +0900, Damien Le Moal wrote:
>> struct blk_zoned {
>> unsigned int nr_zones;
>> unsigned long *seq_zones;
>> };
>>
>> struct request_queue {
>> ...
>> #ifdef CONFIG_BLK_DEV_ZONED
>> struct blk_zoned zoned;
>> #endif
>> ...
>
> Do we even need a new structure for it? I'd just hang it off
> the gendisk directly.
Using a structure just seemed cleaner to me. But it is indeed not really
necessary. As for attaching this info to the gendisk, that would indeed
be equivalent. Having the struct on hand in the request queue just makes
it easier to write small helpers in blkdev.h to access the info. Hence
this choice. Should I change it ?
I have a V3 under test using the blk_zoned struct in the request queue
under test. I will post shortly.
> Except for that the idea looks fine to me.
Thanks !
--
Damien Le Moal,
Western Digital
