Re: [PATCH 1/4] aacraid: interruptible ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -#include <linux/delay.h>
> +#include <linux/delay.h> /* ssleep prototype */

do we really need that comment?

>  #include <linux/kthread.h>
>  #include <asm/semaphore.h>
>  #include <asm/uaccess.h>
> @@ -140,7 +140,8 @@
>  		fibptr->hw_fib_pa = hw_fib_pa;
>  		fibptr->hw_fib = hw_fib;
>  	}
> -	aac_fib_free(fibptr);
> +	if (retval != -EINTR)
> +		aac_fib_free(fibptr);

even if we are interrupted we shouldn't leak the fib, should we?

-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux