On Fri, 2017-09-08 at 11:08 +0800, Ming Lei wrote: > Looks I replied or clarified all your questions/comments on this > patchset. No, you have not addressed all my comments, you know that you have not addressed all my comments so you should not have written that you have addressed all my comments. This patch series not only introduces ugly changes in the request queue freeze mechanism but it also introduces an unacceptable race condition between blk_get_request() and request queue cleanup. BTW, you don't have to spend more time on this patch series. I have implemented an alternative and much cleaner approach to fix SCSI device suspend. I'm currently testing that patch series. Bart.