On Fri, Sep 08, 2017 at 01:16:37AM +0900, Damien Le Moal wrote: > +/* > + * Allocate a zone bitmap (one bit per zone). > + */ > +static inline unsigned long *sd_zbc_alloc_zone_bitmap(struct scsi_disk *sdkp) > +{ > + struct request_queue *q = sdkp->disk->queue; > + > + return kzalloc_node(BITS_TO_LONGS(sdkp->nr_zones) > + * sizeof(unsigned long), > + GFP_KERNEL, q->node); > +} It's a shame we have all this overflow checking kcalloc() and kmalloc_array() functions but none of them is taking NUMA nodes into account. But that has nothing to do with your patch, just a general rant, Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx> -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850