On Wed, Sep 06, 2017 at 11:54:15AM +0200, Stefano Brivio wrote: > Thanks for your feedback! > > I considered doing something similar, but there are different error > coded which are set when we reach the label out_free_mbsx. I checked all > of them (and I hope I didn't miss any), but they all looked correct, > and in quite a few cases different than -EIO (e.g. -ENODEV). > > So I think always returning -EIO in those cases is not what we want. We still could pre-assign the rc value: rc = -EIO; rc = foo() if (rc) goto err_handler; rc = bar() if (rc) goto err_handler; rc = -ENODEV; if (rc) goto somewhere_else; But let's not complicate things and get this one queued up. > > Because as this patch shows there's always a chance to miss an 'rc = -EIO'. > > > > Out of curiosity, do you know what's the value of rc in the failure case? > > Yes, MBXERR_ERROR (mentioned in patch subject -- sorry, I could have > repeated it in the message perhaps). Ah ok I somehow missed it, sorry. Byte, Johannes -- Johannes Thumshirn Storage jthumshirn@xxxxxxx +49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg) Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
