On 02.08.2006 21:24 James Smart <James.Smart@xxxxxxxxxx> wrote: > Sorry folks - a last code review identified one last reference > to seconds_since_last_reset that didn't get caught. Sorry -- for speaking up so lately. > Adding statistics reset callback for FC transport Now lpfc is the second FC driver that stores old stats data in order to reset FC host stats. (zfcp is the other one.) Shouldn't this stuff be moved into scsi_transport_fc? So the default for scsi_transport_fc would be to store a stats-offset (as you call it) together with seconds since last reset. So every FC lldd gets the reset-stats functionality for free. Of course an lldd is able to register its own reset-callback (maybe because the reset is implemented in hardware) to replace the default handler. This just came into my mind when reviewing your patch. Regards, Andreas -- Linux for eServer Development Tel : +49-7031-16-4640 Notes mail : Andreas Herrmann/GERMANY/IBM@IBMDE email : aherrman@xxxxxxxxxx - : send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
