Looks good to me, fixes up the code given that the comment there about calling iscsi_remove_session wasn't being followed. Thanks Acked-by: Chris Leech <cleech@xxxxxxxxxx> On Thu, Jul 13, 2017 at 09:11:21AM -0700, 'Khazhismel Kumykov' via open-iscsi wrote: > Session attributes exposed through sysfs were freed before the device > was destroyed, resulting in a potential use-after-free. Free these > attributes after removing the device. > > Signed-off-by: Khazhismel Kumykov <khazhy@xxxxxxxxxx> > --- > drivers/scsi/libiscsi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c > index 42381adf0769..8696a51a5a0c 100644 > --- a/drivers/scsi/libiscsi.c > +++ b/drivers/scsi/libiscsi.c > @@ -2851,9 +2851,6 @@ EXPORT_SYMBOL_GPL(iscsi_session_setup); > /** > * iscsi_session_teardown - destroy session, host, and cls_session > * @cls_session: iscsi session > - * > - * The driver must have called iscsi_remove_session before > - * calling this. > */ > void iscsi_session_teardown(struct iscsi_cls_session *cls_session) > { > @@ -2863,6 +2860,8 @@ void iscsi_session_teardown(struct iscsi_cls_session *cls_session) > > iscsi_pool_free(&session->cmdpool); > > + iscsi_remove_session(cls_session); > + > kfree(session->password); > kfree(session->password_in); > kfree(session->username); > @@ -2877,7 +2876,8 @@ void iscsi_session_teardown(struct iscsi_cls_session *cls_session) > kfree(session->portal_type); > kfree(session->discovery_parent_type); > > - iscsi_destroy_session(cls_session); > + iscsi_free_session(cls_session); > + > iscsi_host_dec_session_cnt(shost); > module_put(owner); > } > -- > 2.13.2.932.g7449e964c-goog > > -- > You received this message because you are subscribed to the Google Groups "open-iscsi" group. > To unsubscribe from this group and stop receiving emails from it, send an email to open-iscsi+unsubscribe@xxxxxxxxxxxxxxxx. > To post to this group, send email to open-iscsi@xxxxxxxxxxxxxxxx. > Visit this group at https://groups.google.com/group/open-iscsi. > For more options, visit https://groups.google.com/d/optout.