On 08/23/2017 11:40 PM, Bart Van Assche wrote: > This patch avoids that gcc reports the following warning when > building with W=1: > > drivers/scsi/sd.c:315:10: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] > if (val >= 0 && val <= T10_PI_TYPE3_PROTECTION) > > Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx> > --- > drivers/scsi/sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c > index 8b3d7994e182..7c0f9eb5a5fd 100644 > --- a/drivers/scsi/sd.c > +++ b/drivers/scsi/sd.c > @@ -312,7 +312,7 @@ protection_type_store(struct device *dev, struct device_attribute *attr, > if (err) > return err; > > - if (val >= 0 && val <= T10_PI_TYPE3_PROTECTION) > + if (val <= T10_PI_TYPE3_PROTECTION) > sdkp->protection_type = val; > > return count; > Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)
