Re: [PATCH 4/4] fusion: fibre channel: don't sync cache if remote port deleted

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The mid-layer appears to be inconsistent with regard to sync cache.
I agree the sync should not be in the lldd.  It's been in fusion for
a long time and I'm just fixing the implementation for fibre channel.
This isn't a new feature, just a fix to an existing one.

I refer you to two threads which discussed the issue.

http://marc.theaimsgroup.com/?l=linux-scsi&m=115386616817044&w=2
http://marc.theaimsgroup.com/?l=linux-scsi&m=115266599732078&w=2

Mike


James Bottomley wrote:
> On Mon, 2006-07-31 at 12:20 -0500, Michael Reed wrote:
>> mptscsih_slave_destroy issues an unconditional synchronize cache.
> 
> A) mptscsih_slave_destroy shouldn't be doing this ... it should be
> relying on the functionality in the mid-layer.
> 
>> It is not necessary for fibre channel devices for which the rport
>> has been deleted.  This patch creates a new function,
>> mptfc_slave_destroy(), which implements the appropriate test.
> 
> So, this is really code that shouldn't be in a driver, it should be
> higher up.
> 
> The other three patches look fine.
> 
> James
> 
-
: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux