On Wed, Aug 23, 2017 at 02:39:59PM -0700, Bart Van Assche wrote: > Before scsi_prep_fn() calls the ULP .init_command() callback > function it stores the SCSI command pointer in request.special. > This means that the SCpnt = rq->special assignments in the sd > and sr drivers assign a pointer to itself. Hence convert these > two assignment statements into warning statements. Looks good. Reviewed-by: Christoph Hellwig <hch@xxxxxx> Btw, in the longer run we should aim to kill the special pointer in struct request entirely.