Re: [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Bart Van Assche <bart.vanassche@xxxxxxx>
Subject: Re: [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it
From: Christoph Hellwig <hch@xxxxxx>
Date: Thu, 24 Aug 2017 11:05:14 +0200
Cc: "Martin K . Petersen" <martin.petersen@xxxxxxxxxx>, "James E . J . Bottomley" <jejb@xxxxxxxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Bart Van Assche <bart.vanassche@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, Johannes Thumshirn <jthumshirn@xxxxxxx>
In-reply-to: <20170823214009.15015-6-bart.vanassche@wdc.com>
User-agent: Mutt/1.5.17 (2007-11-01)

I don't really see the point of doing more work in exactly the same
amount of code here, especially given that this is the fast path.

Do you need this for any future patches?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it
  - From: Bart Van Assche

References:
- [PATCH 00/19] SCSI patches for kernel v4.14
  - From: Bart Van Assche
- [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it
  - From: Bart Van Assche

Prev by Date: Re: [PATCH 04/19] Convert a strncmp() call into a strcmp() call
Next by Date: Re: [PATCH 06/19] Document which queue type a function is intended for
Previous by thread: [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it
Next by thread: Re: [PATCH 05/19] scsi_setup_fs_cmnd(): Call scsi_req_init() instead of open-coding it
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]