Re: [PATCH 1/6] lpfc 8.1.7 : Adding statistics reset callback for FC transport

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



James Smart wrote:
> Adding statistics reset callback for FC transport
>
> Signed-off-by: James Smart <James.Smart@xxxxxxxxxx>

> -/* FIX ME */
> -	/*hs->SecondsSinceLastReset = (jiffies - lpfc_loadtime) / HZ;*/
> +	hs->seconds_since_last_reset = (jiffies - psli->stats_start) / HZ;

Wraparound?

> +void  lpfc_reset_stats(struct Scsi_Host *shost)
> +{
> +	struct lpfc_hba *phba = (struct lpfc_hba *)shost->hostdata;
> +	struct lpfc_sli *psli = &phba->sli;
> +	struct lpfc_lnk_stat * lso = &psli->lnk_stat_offsets;
> +	LPFC_MBOXQ_t *pmboxq;
> +	MAILBOX_t *pmb;
> +	int rc = 0;
> +
> +	pmboxq = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);
> +	if (!pmboxq)
> +		return;
> +	memset(pmboxq, 0, sizeof (LPFC_MBOXQ_t));
                                ^

No space here.

[...]
> +	memset(pmboxq, 0, sizeof (LPFC_MBOXQ_t));

Again.

Eike

Attachment: pgpmvTCaIuo6K.pgp
Description: PGP signature


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux