On 08/17/2017 04:44 PM, Dan Carpenter wrote:
> The parentheses are in the wrong place so we specify the length as
> "sizeof(this_device->device_id) < 0" which is zero.
>
> Fixes: 988b87edd231 ("scsi: hpsa: Ignore errors for unsupported LV_DEVICE_ID VPD page")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 2773dd7a2087..a22295ee3b70 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -3827,7 +3827,7 @@ static int hpsa_update_device_info(struct ctlr_info *h,
> memset(this_device->device_id, 0,
> sizeof(this_device->device_id));
> if (hpsa_get_device_id(h, scsi3addr, this_device->device_id, 8,
> - sizeof(this_device->device_id) < 0))
> + sizeof(this_device->device_id)) < 0)
> dev_err(&h->pdev->dev,
> "hpsa%d: %s: can't get device id for host %d:C0:T%d:L%d\t%s\t%.16s\n",
> h->ctlr, __func__,
>
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@xxxxxxx +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
